New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestLogger logs sensitive headers #2181

Closed
IssueMonoid opened this Issue Oct 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@IssueMonoid
Contributor

IssueMonoid commented Oct 17, 2018

In the 0.18.x branch of RequestLogger the deprecated apply method ignores redactHeadersWhen when calling logMessage, resulting the default value being passed and hence sensitive headers being logged.

This issue was fixed in:
d0ce8f3

But then reintroduced in:
801b58c

rossabaker added a commit that referenced this issue Oct 17, 2018

Merge pull request #2182 from IssueMonoid/RequestLogger-RedactHeaders
Fix RequestLogger logs sensitive headers #2181
@rossabaker

This comment has been minimized.

Member

rossabaker commented Oct 19, 2018

Fixed by #2182, released in 0.18.20.

@rossabaker rossabaker closed this Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment