Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestLogger ignores redactHeadersWhen #2639

Closed
IssueMonoid opened this issue Jun 12, 2019 · 3 comments
Closed

RequestLogger ignores redactHeadersWhen #2639

IssueMonoid opened this issue Jun 12, 2019 · 3 comments
Labels
bug

Comments

@IssueMonoid
Copy link
Contributor

@IssueMonoid IssueMonoid commented Jun 12, 2019

In server/middleware/RequestLogger.scala the redactHeadersWhen argument is omitted in a call to Logger.logMessage which results in sensitive headers being logged.

@rossabaker rossabaker added the bug label Jun 12, 2019
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 12, 2019

Already a PR open in #2638 for 0.20.x. If you're related to the team that needs it for 0.18.x, I'll cut a release when we get a PR.

@IssueMonoid
Copy link
Contributor Author

@IssueMonoid IssueMonoid commented Jun 12, 2019

yes I submitted a PR for 0.18 #2640

rossabaker added a commit that referenced this issue Jun 12, 2019
Fix leaking sensitive headers RequestLogger #2639
@aeons
Copy link
Member

@aeons aeons commented Jun 13, 2019

Closed by #2641

@aeons aeons closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

No branches or pull requests

3 participants