Unhelpful timeout exception

[tomasherman]

Hello, i found another fairly unhelpful exception coming from http4s:

java.util.concurrent.TimeoutException: Request timeout after 10000 ms
	at org.http4s.client.blaze.BlazeClient$$anon$1.run(BlazeClient.scala:152)
	at monix.execution.schedulers.TracingRunnable.run(TracingRunnable.scala:33)
	at monix.execution.internal.InterceptRunnable.run(InterceptRunnable.scala:27)
	at monix.execution.internal.forkJoin.AdaptedForkJoinTask.exec(AdaptedForkJoinTask.scala:27)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

It would be great if we could add some context - like request that failed and maybe even IP address of the upstream that timeout out.

[tomasherman]

I was hoping to help out by providing a PR but i have a hard time to find all the pieces ... i think what needs to be done is to add information about IP address to BlazeConnection?

Seems like this would be a good place to put that information in: https://github.com/http4s/http4s/blob/master/blaze-client/src/main/scala/org/http4s/client/blaze/Http1Support.scala#L64 ?

[tomasherman]

So there is a bunch of exceptions in BlazeClient and HttpConnection ... i wonder if it would make sense to add to all of them at least the RequestKey ... thoughts?

[rossabaker]

Yes, you could enhance the exceptions by pattern matching Lefts. It will be the same basic tradeoffs as on the other: using the standard Java exception vs. a richer wrapper, with some opportunities to extend the standard Java exceptions like we did in 0.20.

[rossabaker]

Looked a bit closer. I think the timeout you're looking for is here. The RequestKey should be in scope, and we can extend that message.

[tomasherman]

Sure. The one thing I would like to achieve is to have inetaddres available for timeouts as well. But it's going to be more difficult I think. Is it possible to get upstream address from connection? Is it something you would be ok with adding?

…

On Tue, Jan 21, 2020, 17:23 Ross A. Baker ***@***.***> wrote: Looked a bit closer. I think the timeout you're looking for is here <https://github.com/http4s/http4s/blob/a97a153931e324a80a27e4b99129042272c81eac/blaze-client/src/main/scala/org/http4s/client/blaze/BlazeClient.scala#L152>. The RequestKey should be in scope, and we can extend that message. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3087?email_source=notifications&email_token=AAAYMHTNKN5LZJIKZO2ESPTQ64ORLA5CNFSM4KJB3ML2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQKZSY#issuecomment-576761035>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMHRDUBBXKRNDGFN2EGTQ64ORLANCNFSM4KJB3MLQ> .

[tomasherman]

I decided to improve (imho) some logging that we encountered in the wild and would benefited from, hope it's ok

[tomasherman]

fixed in #3089