GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR removes the use of Registry on MediaRange and converts it up to current standards.
Remove Registry from MediaRange
Refactor MediaParser and add some tests
I would have thought this includes media types without the second wild card, but I guess it didn't before?
This is basically replaces the registry with the same set of registered media types as before. Should be fairly mechanical
Hmm. These aren't what I expected them to be. I thought it was keyed by mainType/subType instead of just mainType. I wonder why that is. But you didn't change it.
Well the MediaRange case class only has a mainType unlike MediaType
What surprised me is that the extensions are ignored to set the key
A MediaType is a MediaRange, so I'd expect to be able to look up MediaTypes via the MediaRange companion.
I'm not sure what I think about extensions.
Any ideas to move this forward?
This is approved so I could merge it but if you still want some changes related to the key of the standard map please let me know
Let's merge it now because it's forward progress and then discuss more progress.
Am I weird for thinking the standard media ranges should contain media types since media types are media ranges?
I think it is a valid concern