Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter version of Chunk.toByteBuffer syntax #1602

Merged
merged 1 commit into from Dec 18, 2017

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Dec 18, 2017

We have ByteVectorChunk in part so we can wrap ByteBuffers, and then we forfeit that advantage when converting them back to a ByteBuffer at rendering time.

@rossabaker rossabaker force-pushed the rossabaker:smarter-to-byte-buffer branch to 0fac983 Dec 18, 2017
@aeons
aeons approved these changes Dec 18, 2017
@aeons aeons merged commit 0b31047 into http4s:master Dec 18, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.