New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics fix #1612

Merged
merged 8 commits into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@ChristopherDavenport
Member

ChristopherDavenport commented Dec 23, 2017

  1. GET /http4s/metrics does not increment counters (it’s not wrapped in the middleware)
  2. GET /http4s/metrics does not leave a dangling active request
  3. GET /http4s/dfdajkfldajfklddasfadskl does not leave a dangling active request. (This is one where a wrapped service returns None).
  4. GET /http4s/ping increments 200 and does not leaving dangling active request

Closes #1606

@ChristopherDavenport

This comment has been minimized.

Show comment
Hide comment
@ChristopherDavenport
Member

ChristopherDavenport commented Dec 23, 2017

Fixes #1606

@jmcardon

Small changes re: liftF and possibly snake case, but otherwise great stuff @ChristopherDavenport 👍

@jmcardon

👍 After the remaining snakes are killed

@rossabaker rossabaker merged commit 580935d into http4s:master Dec 23, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment