Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailer headers and add a test for it #1629

Merged
merged 1 commit into from Jan 17, 2018
Merged

Conversation

@aeons
Copy link
Member

@aeons aeons commented Jan 17, 2018

Fixes #1628

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 17, 2018

Looks good in the appveyor. Looks like something happened with travis do you want to retrigger?

Copy link
Member

@bryce-anderson bryce-anderson left a comment

Lgtm.

Copy link
Member

@rossabaker rossabaker left a comment

Didn't @jzweifel report this on 0.17? I would not be surprised if this is an old bug, if we care to backport it.

aeons added a commit to aeons/http4s that referenced this pull request Jan 17, 2018
@aeons aeons merged commit 05cd602 into http4s:master Jan 17, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeons aeons deleted the aeons:fix-trailer-headers branch Jan 17, 2018
aeons added a commit that referenced this pull request Jan 17, 2018
Fix trailer headers (backport of #1629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants