Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immediately returning serve #1638

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 23, 2018

Not sure about the EC, but once translate bug is fixed this work as expected.

_.shutdown)
(_: Server[F]) =>
Stream.eval(terminateWhenTrue.discrete.takeWhile(_ == false).compile.drain) >>
Stream.emit(StreamApp.ExitCode(0)).covary[F],

This comment has been minimized.

@aeons

aeons Jan 23, 2018
Member

This should use the Success constant.

@aeons
aeons approved these changes Jan 23, 2018
Copy link
Member

@aeons aeons left a comment

Looks good.

@aeons
Copy link
Member

@aeons aeons commented Jan 24, 2018

👍 on the exit code ref

@ChristopherDavenport ChristopherDavenport merged commit 7d3ebff into http4s:master Jan 24, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ChristopherDavenport ChristopherDavenport deleted the ChristopherDavenport:fixImmediatelyReturningServe branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.