Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
ioganegambaputifonguser
referenced this pull request
Mar 2, 2018
Closed
Handling of faults tends to lead to duplication with external handling and over-verbose logging #728
| <root level="${LOGBACK_ROOT_LEVEL:-WARN}"> | ||
| <appender-ref ref="STDOUT" /> | ||
| </root> | ||
| </configuration> |
This comment has been minimized.
This comment has been minimized.
rossabaker
Mar 8, 2018
•
Member
Surprised this file is necessary. This has a test->test dependency from testing, so why is this not on the classpath already?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Deleted |
ChristopherDavenport
approved these changes
Mar 10, 2018
Since you can't really opt out, I think this one makes sense. Might make sense to downgrade to debug, but I think the result of a failed call is likely going to serve most cases so I think this is a good initial shift.
rossabaker
approved these changes
Mar 10, 2018
I'm going to cherry pick this back to release-0.18.x so people can use it sooner.
This comment has been minimized.
This comment has been minimized.
|
Cherry-picked and merged to master. Thanks! |
rossabaker
closed this
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ioganegambaputifonguser commentedMar 2, 2018
fixes #728 Remove over logging in the pool manager. Add log4s configuration for the blaze-client test.