Remove over logging in the pool manager #1683
Closed
Conversation
…ration for the blaze-client test.
|
Thanks! Quick question on the logback file. |
| <root level="${LOGBACK_ROOT_LEVEL:-WARN}"> | ||
| <appender-ref ref="STDOUT" /> | ||
| </root> | ||
| </configuration> |
rossabaker
Mar 8, 2018
•
Member
Surprised this file is necessary. This has a test->test dependency from testing, so why is this not on the classpath already?
Surprised this file is necessary. This has a test->test dependency from testing, so why is this not on the classpath already?
ChristopherDavenport
Mar 8, 2018
Member
Right, I'd feel much more comfortable without this file.
Right, I'd feel much more comfortable without this file.
|
Deleted |
|
Since you can't really opt out, I think this one makes sense. Might make sense to downgrade to debug, but I think the result of a failed call is likely going to serve most cases so I think this is a good initial shift. |
|
I'm going to cherry pick this back to release-0.18.x so people can use it sooner. |
|
Cherry-picked and merged to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #728 Remove over logging in the pool manager. Add log4s configuration for the blaze-client test.