Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove over logging in the pool manager #1683

Conversation

@feodor-shi
Copy link
Contributor

@feodor-shi feodor-shi commented Mar 2, 2018

fixes #728 Remove over logging in the pool manager. Add log4s configuration for the blaze-client test.

…ration for the blaze-client test.
Copy link
Member

@rossabaker rossabaker left a comment

Thanks! Quick question on the logback file.

<root level="${LOGBACK_ROOT_LEVEL:-WARN}">
<appender-ref ref="STDOUT" />
</root>
</configuration>

This comment has been minimized.

@rossabaker

rossabaker Mar 8, 2018
Member

Surprised this file is necessary. This has a test->test dependency from testing, so why is this not on the classpath already?

This comment has been minimized.

@ChristopherDavenport

ChristopherDavenport Mar 8, 2018
Member

Right, I'd feel much more comfortable without this file.

@feodor-shi
Copy link
Contributor Author

@feodor-shi feodor-shi commented Mar 10, 2018

Deleted

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Since you can't really opt out, I think this one makes sense. Might make sense to downgrade to debug, but I think the result of a failed call is likely going to serve most cases so I think this is a good initial shift.

Copy link
Member

@rossabaker rossabaker left a comment

I'm going to cherry pick this back to release-0.18.x so people can use it sooner.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Mar 10, 2018

Cherry-picked and merged to master. Thanks!

@rossabaker rossabaker closed this Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants