New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make retry use the correct duration units #1698

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@edmundnoble
Contributor

edmundnoble commented Mar 9, 2018

Used to convert everything to seconds wrong (as in, 5.millis => 5.seconds), now just does the entire max computation inside Duration.

@rossabaker

This comment has been minimized.

Member

rossabaker commented Mar 10, 2018

👍 I'll cherry pick this onto release-0.18.x. The macro fix can be, too.

@rossabaker rossabaker referenced this pull request Mar 10, 2018

Merged

Release v0.18.2 #1700

@rossabaker

This comment has been minimized.

Member

rossabaker commented Mar 10, 2018

Cherry-picked into #1700. Will be released in v0.18.2.

@rossabaker rossabaker closed this Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment