New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds request/response specific properties to logging #1709

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@megri
Contributor

megri commented Mar 15, 2018

  • Request: method, http-version, uri
  • Response: status, http-version

Resolves #1708

megri added some commits Mar 15, 2018

adds request/response specific properties to logging
* Request: method, http-version, uri
* Response: status, http-version
@megri

This comment has been minimized.

Contributor

megri commented Mar 15, 2018

Sample output:

Request: o.h.server.middleware.RequestLogger HTTP/1.1 POST /api/items?foo=bar Headers(Host: localhost:8080, User-Agent: curl/7.54.0, Accept: */*)

Response: o.h.server.middleware.ResponseLogger HTTP/1.1 422 Unprocessable Entity Headers(Content-Length: 108, Content-Type: text/plain; charset=UTF-8)

@rossabaker

The code looks sound to me. We could cherry-pick this back into 0.18.3 so it's out there sooner.

@jmcardon

LGTM

@ChristopherDavenport

Let's cherry pick it.

@rossabaker

This comment has been minimized.

Member

rossabaker commented Mar 16, 2018

Cherry-picked. This will be in 0.18.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment