Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds request/response specific properties to logging #1709

Closed
wants to merge 3 commits into from

Conversation

@megri
Copy link
Contributor

@megri megri commented Mar 15, 2018

  • Request: method, http-version, uri
  • Response: status, http-version

Resolves #1708

megri added 3 commits Mar 15, 2018
* Request: method, http-version, uri
* Response: status, http-version
@megri
Copy link
Contributor Author

@megri megri commented Mar 15, 2018

Sample output:

Request: o.h.server.middleware.RequestLogger HTTP/1.1 POST /api/items?foo=bar Headers(Host: localhost:8080, User-Agent: curl/7.54.0, Accept: */*)

Response: o.h.server.middleware.ResponseLogger HTTP/1.1 422 Unprocessable Entity Headers(Content-Length: 108, Content-Type: text/plain; charset=UTF-8)

Copy link
Member

@rossabaker rossabaker left a comment

The code looks sound to me. We could cherry-pick this back into 0.18.3 so it's out there sooner.

Copy link
Member

@jmcardon jmcardon left a comment

LGTM

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Let's cherry pick it.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Mar 16, 2018

Cherry-picked. This will be in 0.18.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants