adds request/response specific properties to logging #1709
Closed
Conversation
* Request: method, http-version, uri * Response: status, http-version
Sample output: Request: Response: |
The code looks sound to me. We could cherry-pick this back into 0.18.3 so it's out there sooner. |
LGTM |
Let's cherry pick it. |
Cherry-picked. This will be in 0.18.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Resolves #1708