Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expectOr methods for custom error handling on failed expects #1726

Merged
merged 1 commit into from Mar 23, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Mar 23, 2018

Reopening #1634 so we can get it across the finish line. It looks like this is binary compatible. Apologies for this falling off my radar.

Is this helpful as is, or do we want to address the discussion in #1632 to make it useful?

/cc @kailuowang

@rossabaker rossabaker force-pushed the release-0.18.x branch from 8ab845f to db2a0a0 Mar 23, 2018
@rossabaker rossabaker force-pushed the issue-1632 branch from 6ec447b to 0c643c8 Mar 23, 2018
@kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Mar 23, 2018

👍 Definitely helpful for my use cases.

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Mar 23, 2018

Alright, MiMa liked this. We can get this into 0.18.4 if it's positively reviewed.

@aeons
aeons approved these changes Mar 23, 2018
Copy link
Member

@aeons aeons left a comment

👍

@rossabaker rossabaker merged commit d293c6a into release-0.18.x Mar 23, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker deleted the issue-1632 branch Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants