Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
rossabaker
force-pushed the
release-0.18.x
branch
from
8ab845f
to
db2a0a0
Mar 23, 2018
rossabaker
force-pushed the
issue-1632
branch
from
6ec447b
to
0c643c8
Mar 23, 2018
This comment has been minimized.
This comment has been minimized.
kailuowang
commented
Mar 23, 2018
|
|
This comment has been minimized.
This comment has been minimized.
|
Alright, MiMa liked this. We can get this into 0.18.4 if it's positively reviewed. |
rossabaker
merged commit d293c6a
into
release-0.18.x
Mar 23, 2018
rossabaker
deleted the
issue-1632
branch
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rossabaker commentedMar 23, 2018
Reopening #1634 so we can get it across the finish line. It looks like this is binary compatible. Apologies for this falling off my radar.
Is this helpful as is, or do we want to address the discussion in #1632 to make it useful?
/cc @kailuowang