Add expectOr methods for custom error handling on failed expects #1726
Conversation
|
|
|
Alright, MiMa liked this. We can get this into 0.18.4 if it's positively reviewed. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reopening #1634 so we can get it across the finish line. It looks like this is binary compatible. Apologies for this falling off my radar.
Is this helpful as is, or do we want to address the discussion in #1632 to make it useful?
/cc @kailuowang