New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place Show[EntityTag] in the companion object #1749

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
2 participants
@cquiroz
Member

cquiroz commented Mar 28, 2018

This is a leftover change from PR #1739 applicable to master

@cquiroz

This comment has been minimized.

Member

cquiroz commented Mar 28, 2018

This is odd. Travis is failing in 2.12 with this

[tut] *** Error reported at /home/travis/build/http4s/http4s/docs/src/main/tut/testing.md:40
// <console>:46: warning: method withBody in trait Message is deprecated (since 0.19): Use withEntity
//              case Some(user) => Response(status = Status.Ok).withBody(user.asJson)
//                                                              ^
// error: No warnings can be incurred under -Xfatal-warnings.

Any ideas?

@rossabaker

This comment has been minimized.

Member

rossabaker commented Mar 28, 2018

We renamed it to withEntity when it stopped being effectful. And it's only happening in 2.12 because of the tuts. And I think it's acting up now because we merged a tut from 0.18. You didn't break this.

@rossabaker rossabaker merged commit e75c730 into http4s:master Mar 28, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@cquiroz cquiroz deleted the cquiroz:etag-show branch Mar 28, 2018

@rossabaker rossabaker referenced this pull request Apr 20, 2018

Open

Release strategy: 0.19 and 1.0 #1797

19 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment