Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cats.effect.Timer for Retry middleware #1754

Merged
merged 2 commits into from Mar 28, 2018
Merged

Conversation

@aeons
Copy link
Member

@aeons aeons commented Mar 28, 2018

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

But see comment.

@@ -54,7 +50,7 @@ object Retry {
duration: FiniteDuration,
retryHeader: Option[`Retry-After`])(
implicit F: Effect[F],
executionContext: ExecutionContext): F[DisposableResponse[F]] = {
T: Timer[F]): F[DisposableResponse[F]] = {

This comment has been minimized.

@rossabaker

rossabaker Mar 28, 2018
Member

Don't these implicits just shadow the ones in apply?

This comment has been minimized.

@aeons

aeons Mar 28, 2018
Author Member

Yes, I didn't pay enough attention to the indentation in this file. Thought they were separate things.

@aeons aeons merged commit 9655331 into http4s:master Mar 28, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeons aeons deleted the aeons:retry-with-timer branch Mar 28, 2018
@rossabaker rossabaker mentioned this pull request Apr 20, 2018
19 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants