New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cats.effect.Timer for Retry middleware #1754

merged 2 commits into from Mar 28, 2018


None yet
3 participants

aeons commented Mar 28, 2018

No description provided.


But see comment.

@@ -54,7 +50,7 @@ object Retry {
duration: FiniteDuration,
retryHeader: Option[`Retry-After`])(
implicit F: Effect[F],
executionContext: ExecutionContext): F[DisposableResponse[F]] = {
T: Timer[F]): F[DisposableResponse[F]] = {

This comment has been minimized.


rossabaker Mar 28, 2018


Don't these implicits just shadow the ones in apply?

This comment has been minimized.


aeons Mar 28, 2018


Yes, I didn't pay enough attention to the indentation in this file. Thought they were separate things.

@aeons aeons merged commit 9655331 into http4s:master Mar 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@aeons aeons deleted the aeons:retry-with-timer branch Mar 28, 2018

@rossabaker rossabaker referenced this pull request Apr 20, 2018


Release strategy: 0.19 and 1.0 #1797

19 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment