Use cats.effect.Timer for Retry middleware #1754
Merged
Conversation
|
But see comment. |
| @@ -54,7 +50,7 @@ object Retry { | |||
| duration: FiniteDuration, | |||
| retryHeader: Option[`Retry-After`])( | |||
| implicit F: Effect[F], | |||
| executionContext: ExecutionContext): F[DisposableResponse[F]] = { | |||
| T: Timer[F]): F[DisposableResponse[F]] = { | |||
rossabaker
Mar 28, 2018
Member
Don't these implicits just shadow the ones in apply?
Don't these implicits just shadow the ones in apply?
aeons
Mar 28, 2018
Author
Member
Yes, I didn't pay enough attention to the indentation in this file. Thought they were separate things.
Yes, I didn't pay enough attention to the indentation in this file. Thought they were separate things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.