New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stream constructor for async-http-client #1776

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
2 participants
@rossabaker
Member

rossabaker commented Apr 11, 2018

Added this while investigating #1774.

The apply method should return an effect. It's inconsistent with Http1Client, and that one is better. But we can't fix that here.

@rossabaker rossabaker force-pushed the rossabaker:async-http-client-stream branch from ec41445 to af11fc2 Apr 11, 2018

@rossabaker rossabaker merged commit 7f50c33 into http4s:release-0.18.x Apr 11, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:async-http-client-stream branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment