Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
rossabaker
dismissed
ChristopherDavenport’s
stale review
Apr 28, 2018
It turned out to not be green
rossabaker
changed the title from
Upgrade to scala-2.12.6
to
Upgrade to scala-2.12.6, drop macro-compat
Apr 28, 2018
| @@ -9,6 +9,7 @@ ordered chronologically, so each release contains all changes described below | ||
| it. | ||
| # v0.18.10-SNAPSHOT | ||
| * Eliminate dependnecy on Macro Paradise and macro-compat [#1816](https://github.com/http4s/http4s/pull/1816) |
This comment has been minimized.
This comment has been minimized.
rossabaker
merged commit fd4d3b8
into
http4s:release-0.18.x
Apr 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rossabaker commentedApr 27, 2018
•
edited
Macro Paradise is not yet available for 2.12.6 and won't be for 2.13. It appears we only needed it to bridge the macro gap to Scala 2.10, which is no longer an issue.
Fixes #1803.