Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the blaze-client tick wheel executor lazy #1822

Merged

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 2, 2018

Having a resource allocated in an object is something we want to address in #1821. Meanwhile, @lbialy made this monkey patch for his Graal work, and I don't see any downside for regular use.

@bryce-anderson
Copy link
Member

@bryce-anderson bryce-anderson commented May 2, 2018

Seems reasonable. It looks like a lazy is that blaze is already doing. The blaze library uses it's private/lazy executor a lot. I think this is a product of not having a coherent way to configure pipelines.

@rossabaker rossabaker merged commit dbfe681 into http4s:release-0.18.x May 3, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker deleted the rossabaker:lazy-tick-wheel-executor branch May 3, 2018
@lbialy
Copy link

@lbialy lbialy commented May 3, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.