Fix deadlock in client logging middleware #1837
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Going to and from HttpService in the client logging middleware means dispose isn't called.🤕
Unit testing this is tricky: the problem is in the client project, and we'd normally test that with
Client.fromHttpService, but that has a trivialdisposemethod. We need to test this somewhere we have a real client. I manually tested this with the reproduction in #1833.When merged to master, apply0 will replace apply.
Fixes #1833.
/cc @rhyskeepence