New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in client logging middleware #1837

Merged
merged 2 commits into from May 9, 2018

Conversation

Projects
None yet
2 participants
@rossabaker
Member

rossabaker commented May 9, 2018

Going to and from HttpService in the client logging middleware means dispose isn't called. 馃

Unit testing this is tricky: the problem is in the client project, and we'd normally test that with Client.fromHttpService, but that has a trivial dispose method. We need to test this somewhere we have a real client. I manually tested this with the reproduction in #1833.

When merged to master, apply0 will replace apply.

Fixes #1833.

/cc @rhyskeepence

@rossabaker rossabaker added the bug label May 9, 2018

@rossabaker rossabaker force-pushed the rossabaker:issue-1833 branch from 6d608dc to 9b47a08 May 9, 2018

@rossabaker rossabaker merged commit bf54820 into http4s:release-0.18.x May 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:issue-1833 branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment