Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Removed fixed log level from Logger #1839
A small PR to remove
referenced this pull request
May 9, 2018
One thing I just noticed about our Logger implementation is that we construct the String whether or not the logging level is enabled.
logger.info(s) avoids the construction of an expensive
s, whereas this signature materializes the string before passing it off to
Then again, we're paying for the string anyway in the current implementation. So I think this is an improvement, but we can still do better here.