New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OkHttp client (with HTTP/2) (to 0.18) #1864

Merged
merged 12 commits into from May 25, 2018

Conversation

Projects
None yet
3 participants
@andimiller
Contributor

andimiller commented May 16, 2018

This adds an OkHttp implementation for Client.

This is heavily based on the one for async-http-client.

The motivation for this is to have a Client backend which is capable of HTTP/2.

This PR continues #1851 and is against release-0.18.x in stead of master

andimiller added some commits May 10, 2018

andimiller added some commits May 16, 2018

@rossabaker

👍

@jmcardon

LGTM aside from possibly that error swallowing

}
},
F.delay({
try {

This comment has been minimized.

@jmcardon

jmcardon May 25, 2018

Member

Should we accumulate these errors here? Seems like we're swallowing an awful lot of stuff.

This comment has been minimized.

@rossabaker

rossabaker May 25, 2018

Member

They're all being logged, and OkHttp eventually shuts down idle resources anyway. See discussion on #1851. I think we're fine here.

@rossabaker rossabaker merged commit b829df8 into http4s:release-0.18.x May 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment