Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OkHttp client (with HTTP/2) (to 0.18) #1864

merged 12 commits into from May 25, 2018


Copy link

@andimiller andimiller commented May 16, 2018

This adds an OkHttp implementation for Client.

This is heavily based on the one for async-http-client.

The motivation for this is to have a Client backend which is capable of HTTP/2.

This PR continues #1851 and is against release-0.18.x in stead of master

andimiller added 10 commits May 10, 2018
andimiller added 2 commits May 16, 2018
Copy link

@rossabaker rossabaker left a comment


Copy link

@jmcardon jmcardon left a comment

LGTM aside from possibly that error swallowing

try {

This comment has been minimized.


jmcardon May 25, 2018

Should we accumulate these errors here? Seems like we're swallowing an awful lot of stuff.

This comment has been minimized.


rossabaker May 25, 2018

They're all being logged, and OkHttp eventually shuts down idle resources anyway. See discussion on #1851. I think we're fine here.

@rossabaker rossabaker merged commit b829df8 into http4s:release-0.18.x May 25, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants