Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when no response is returned or an error is raised #1879

Merged

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 27, 2018

Not sure whether to call this a bug or an enhancement.

The need for the orElse is all the more reason for HttpApp.

The need for the handleErrrorWith is all the more reason we need a lower level logger for blaze.

@rossabaker rossabaker force-pushed the rossabaker:response-logger-unhappy-paths branch from 5888f68 to ab1d148 May 27, 2018
@rossabaker rossabaker mentioned this pull request May 27, 2018
@rossabaker rossabaker merged commit ee346d6 into http4s:release-0.18.x May 27, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker deleted the rossabaker:response-logger-unhappy-paths branch May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.