Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
rossabaker
added
the
enhancement
label
May 28, 2018
| object HttpURLConnectionClient { | ||
| /** Construct a new Client */ | ||
| def apply[F[_]](implicit F: Effect[F]): Client[F] = |
This comment has been minimized.
This comment has been minimized.
rossabaker
referenced this pull request
May 31, 2018
Open
ServerBuilder should accept a Server header configuration setting #1905
rossabaker
requested review from
SystemFw and
ChristopherDavenport
Jun 17, 2018
rossabaker
force-pushed the
rossabaker:http-url-connection-client
branch
from
f3906bc
to
b63346b
Jun 17, 2018
| import scala.concurrent.ExecutionContext | ||
| package object internal { | ||
| def blocking[F[_], A](fa: F[A], blockingExecutionContext: ExecutionContext)(implicit F: Async[F], ec: ExecutionContext): F[A] = |
This comment has been minimized.
This comment has been minimized.
rossabaker
Jun 17, 2018
Member
This looks a lot like @ChristopherDavenport's linebacker 0.1 and the not ideal combinator in @SystemFw's gist.
Better can be done with bracket. Better still can be done with rank-N types. But maybe this is the best we can do now?
| val hostnameVerifier: Option[HostnameVerifier], | ||
| val sslSocketFactory: Option[SSLSocketFactory], | ||
| val blockingExecutionContext: ExecutionContext, | ||
| )(implicit ec: ExecutionContext) { |
This comment has been minimized.
This comment has been minimized.
rossabaker
Jun 17, 2018
Member
This is a good example of what I have in mind for the client and server configurations. This can be evolved by adding more values. Generating the with methods is tedious, but I think compatibility wins here.
This comment has been minimized.
This comment has been minimized.
rossabaker
Jun 17, 2018
Member
Maybe having types named BlahClient create a plain old Client is confusing. We could all this a JavaNetClientBuilder or JavaNetClientConfig, but I like the shape.
SystemFw
reviewed
Jun 17, 2018
Quite useful in the REPL, yeah.
Eventually blocking should be in cats-effect and using bracket (for posterity, you already know this :) )
This comment has been minimized.
This comment has been minimized.
|
It's still not great. The body I/O blocks. |
rossabaker
dismissed
SystemFw’s
stale review
Jun 18, 2018
Added double shift for bodies
| @@ -0,0 +1,39 @@ | ||
| http4s | ||
| Copyright 2013-2018 http4s.org | ||
| Licensed under Apache License 2.0 (see LICENSE) |
This comment has been minimized.
This comment has been minimized.
rossabaker
Jun 18, 2018
Member
We're technically supposed to include the license of all the projects we copied from. I took the liberty of doing so while adding yet another project to copy and paste from.
A former employer's lawyer once told me we need to have the copyright boilerplate on all our source files. I told him not while we were maintaining multiple branches. But maybe now is a good time. But that's a discussion for another ticket.
| fa0 <- F.fromEither(att) | ||
| } yield fa0 | ||
| /** Like fs2.io.readInputStream, but does a double shift with [[blocking]]. */ |
This comment has been minimized.
This comment has been minimized.
rossabaker
Jun 18, 2018
Member
I think everything from here below disappears in fs2-1.0, because it does a double shift. This is basically all a backport to fs2-0.10.
| Licensed under Apache License 2.0 (see LICENSE) | ||
| This software contains portions of code derived from finagle | ||
| https://github.com/twitter/finagle |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Bump. I dismissed @SystemFw's earlier approval due to substantial changes. |
rossabaker
requested review from
SystemFw and
aeons
Jul 3, 2018
aeons
approved these changes
Jul 3, 2018
We can't really get around this blocking somewhere, so I think packing it away like this is a good solution.
This comment has been minimized.
This comment has been minimized.
|
It's a bit of a shame since the main use for this is probably the repl, where you normally just import |
This comment has been minimized.
This comment has been minimized.
|
Yeah, it made it slightly more awkward to use in the REPL, but it'll be a bit more consistent with our other java.io builders. You know, we could have a |
rossabaker commentedMay 28, 2018
It's not production grade. It blocks. But it comes with no extra dependencies, doesn't need to be shut down, and is nice for a REPL session.