Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ServerSoftware to top-level package #1884

Merged
merged 2 commits into from May 30, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 30, 2018

http4s-core shouldn't have anything in the org.http4s.server package.

rossabaker added 2 commits May 30, 2018
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented May 30, 2018

Broken because #1887.

@aeons
aeons approved these changes May 30, 2018
Copy link
Member

@aeons aeons left a comment

Do we hold merges for #1887 ?

@rossabaker rossabaker merged commit 7bb55b5 into http4s:master May 30, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented May 30, 2018

If they passed appveyor, and Travis failed on the tut from #1887, I'm counting that as a pass, since it's obvious what the problem is.

@rossabaker rossabaker deleted the rossabaker:move-server-software branch May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants