Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize CORS middleware #1889

Merged
merged 2 commits into from May 30, 2018
Merged

Generalize CORS middleware #1889

merged 2 commits into from May 30, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 30, 2018

No description provided.

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented May 30, 2018

Was submitted while #1887 was broken.

@deprecatedName('service) http: Http[F, G],
config: CORSConfig = DefaultCORSConfig)(
implicit F: Applicative[F],
G: Functor[G]): Http[F, G] =

This comment has been minimized.

@aeons

aeons May 30, 2018
Member

Could these implicits be added as context bounds instead?

@aeons aeons merged commit 76c98e9 into http4s:master May 30, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants