Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
| object URITranslation { | ||
| def translateRoot[F[_]: Functor](prefix: String)( | ||
| @deprecatedName('service) routes: HttpRoutes[F]): HttpRoutes[F] = { | ||
| def translateRoot[F[_], G[_]: Functor, A](prefix: String)( |
This comment has been minimized.
This comment has been minimized.
rossabaker
May 30, 2018
Member
I think I called this B in another one, just so response was always B. But I also thought about just using the first available letter like this. They're obviously equivalent.
Does anyone have a strong preference? My primary preference is only for consistency. I guess maybe I like the style here better.
This comment has been minimized.
This comment has been minimized.
tomwadeson
May 30, 2018
Contributor
No preference here. With you on the consistency front, so am happy to change!
rossabaker
referenced this pull request
May 30, 2018
Closed
Parameterize `URITranslation` middleware #1901
tomwadeson
force-pushed the
tomwadeson:parameterize-uri-translation
branch
from
77ede8f
to
cd5c73a
May 31, 2018
rossabaker
requested changes
May 31, 2018
There was a mild preference for B on Gitter. Let's change that, and I think we're all set on this one.
tomwadeson
added some commits
May 30, 2018
tomwadeson
force-pushed the
tomwadeson:parameterize-uri-translation
branch
from
cd5c73a
to
504e49c
May 31, 2018
rossabaker
merged commit 48836b4
into
http4s:master
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tomwadeson commentedMay 30, 2018
Relates to: #1890