Parameterize `URITranslation` middleware #1895
Merged
Conversation
|
|
||
| object URITranslation { | ||
| def translateRoot[F[_]: Functor](prefix: String)( | ||
| @deprecatedName('service) routes: HttpRoutes[F]): HttpRoutes[F] = { | ||
| def translateRoot[F[_], G[_]: Functor, A](prefix: String)( |
rossabaker
May 30, 2018
Member
I think I called this B in another one, just so response was always B. But I also thought about just using the first available letter like this. They're obviously equivalent.
Does anyone have a strong preference? My primary preference is only for consistency. I guess maybe I like the style here better.
I think I called this B in another one, just so response was always B. But I also thought about just using the first available letter like this. They're obviously equivalent.
Does anyone have a strong preference? My primary preference is only for consistency. I guess maybe I like the style here better.
tomwadeson
May 30, 2018
Author
Contributor
No preference here. With you on the consistency front, so am happy to change!
No preference here. With you on the consistency front, so am happy to change!
tomwadeson
force-pushed the
tomwadeson:parameterize-uri-translation
branch
from
77ede8f
to
cd5c73a
|
There was a mild preference for |
tomwadeson
force-pushed the
tomwadeson:parameterize-uri-translation
branch
from
cd5c73a
to
504e49c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Relates to: #1890