New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize `URITranslation` middleware #1895

Merged
merged 3 commits into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@tomwadeson
Contributor

tomwadeson commented May 30, 2018

Relates to: #1890

object URITranslation {
def translateRoot[F[_]: Functor](prefix: String)(
@deprecatedName('service) routes: HttpRoutes[F]): HttpRoutes[F] = {
def translateRoot[F[_], G[_]: Functor, A](prefix: String)(

This comment has been minimized.

@rossabaker

rossabaker May 30, 2018

Member

I think I called this B in another one, just so response was always B. But I also thought about just using the first available letter like this. They're obviously equivalent.

Does anyone have a strong preference? My primary preference is only for consistency. I guess maybe I like the style here better.

This comment has been minimized.

@tomwadeson

tomwadeson May 30, 2018

Contributor

No preference here. With you on the consistency front, so am happy to change!

@tomwadeson tomwadeson force-pushed the tomwadeson:parameterize-uri-translation branch from 77ede8f to cd5c73a May 31, 2018

@rossabaker

There was a mild preference for B on Gitter. Let's change that, and I think we're all set on this one.

@tomwadeson tomwadeson force-pushed the tomwadeson:parameterize-uri-translation branch from cd5c73a to 504e49c May 31, 2018

@rossabaker rossabaker merged commit 48836b4 into http4s:master Jun 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment