Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize `VirtualHost` middleware #1902

Merged
merged 4 commits into from May 31, 2018

Conversation

@tomwadeson
Copy link
Contributor

@tomwadeson tomwadeson commented May 30, 2018

Relates to: #1890

tomwadeson added 2 commits May 30, 2018
final case class HostService[F[_]](
@deprecatedName('service) routes: HttpRoutes[F],
final case class HostService[F[_], G[_]](
@deprecatedName('service) http: Kleisli[F, Request[G], Response[G]],

This comment has been minimized.

@rossabaker

rossabaker May 31, 2018
Member

Do we want to use the Http[F, G] alias instead of Kleisli[F, Request[G], Response[G]]? I'm inclined toward yes.

Copy link
Member

@rossabaker rossabaker left a comment

👍

@rossabaker rossabaker merged commit 4b0b254 into http4s:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants