Parameterize `VirtualHost` middleware #1902
Merged
Conversation
| final case class HostService[F[_]]( | ||
| @deprecatedName('service) routes: HttpRoutes[F], | ||
| final case class HostService[F[_], G[_]]( | ||
| @deprecatedName('service) http: Kleisli[F, Request[G], Response[G]], |
rossabaker
May 31, 2018
Member
Do we want to use the Http[F, G] alias instead of Kleisli[F, Request[G], Response[G]]? I'm inclined toward yes.
Do we want to use the Http[F, G] alias instead of Kleisli[F, Request[G], Response[G]]? I'm inclined toward yes.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Relates to: #1890