Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
tomwadeson
added some commits
May 30, 2018
| final case class HostService[F[_]]( | ||
| @deprecatedName('service) routes: HttpRoutes[F], | ||
| final case class HostService[F[_], G[_]]( | ||
| @deprecatedName('service) http: Kleisli[F, Request[G], Response[G]], |
This comment has been minimized.
This comment has been minimized.
rossabaker
May 31, 2018
Member
Do we want to use the Http[F, G] alias instead of Kleisli[F, Request[G], Response[G]]? I'm inclined toward yes.
rossabaker
merged commit 4b0b254
into
http4s:master
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tomwadeson commentedMay 30, 2018
Relates to: #1890