Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downcase type in MediaRange generator #1907

Merged
merged 2 commits into from Jun 3, 2018

Conversation

@aeons
Copy link
Member

@aeons aeons commented Jun 1, 2018

Fixes #1891

(also update sbt to 1.1.6)

@aeons aeons changed the title Downcase type in MediaRange generator Fixes #1891 Downcase type in MediaRange generator Jun 1, 2018
@cquiroz
cquiroz approved these changes Jun 1, 2018
Copy link
Member

@cquiroz cquiroz left a comment

LGTM, I think there was another Pr with the sbt update, but the generator fix looks fine

@aeons
Copy link
Member Author

@aeons aeons commented Jun 1, 2018

That was for master :)

@rossabaker rossabaker merged commit 299f615 into http4s:release-0.18.x Jun 3, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeons aeons deleted the aeons:fix-mediarange-gen branch Jun 3, 2018
rossabaker added a commit to rossabaker/http4s that referenced this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants