Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Altered Logger, RequestLogger and ResponseLogger to be more parametric using Kleisli #1916
Couple of concerns:
Thanks in advance for review and feedback.
Thanks, @aworton. Sorry for the slow review. I got busy late last week.
None point is interesting. It's unfortunate that in the 0.18 version we have to speculate how the server will ultimately respond to a
Logger works better on a total function. I think that raises two possibilities:
- Make it work only on
HttpApp. This is less general than it could be, but steers toward more accurate usage.
- Proceed as with this PR and hope people use it tastefully.
I might lean toward the first. What do you think?
Tried relaxing Effect to Sync, but without current success, lowered implicits to Sync, kept type parameter at Effect for consistency.
If I understand correctly, switching from HttpRoutes to HttpApp means the ability to selectively apply logging to particular routes only is lost. Although I'm not sure if that is that likely to be a common usage, and applying the loggers once to the HttpApp simplifies use.
I think the build failure is intermittent. Rerunning.
That's correct. I think getting rid of the
Only thing I want to discuss is the default global arg.
Could we smite this?