Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoSlash in Router #1937

Closed
wants to merge 1 commit into from
Closed

Fix AutoSlash in Router #1937

wants to merge 1 commit into from

Conversation

@aeons
Copy link
Member

@aeons aeons commented Jul 5, 2018

Fixes #1378 (again)

The problem is that just doing withPathInfo, the "translated-away" prefix of the prefixed route is added again.

This PR fixes that by calling translateRoot on the service with a prefix of req.scriptName.

I'm not sure this is a good way of solving the problem, but it was the one I could see.

Fixes #1378 (again)
aeons added a commit to aeons/http4s that referenced this pull request Jul 5, 2018
aeons added a commit to aeons/http4s that referenced this pull request Jul 5, 2018
Copy link
Member

@rossabaker rossabaker left a comment

👍, but I'm going to merge #1938 first and run a merge train and maybe just close this one.

rossabaker added a commit that referenced this pull request Jul 5, 2018
Backport of #1937 to 0.18
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jul 5, 2018

Incorporated via merge.

@rossabaker rossabaker closed this Jul 5, 2018
@aeons aeons deleted the aeons:feature/fix-1378 branch Jul 5, 2018
@aeons
Copy link
Member Author

@aeons aeons commented Jul 5, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.