Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StaticHeaders middleware #1939

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jul 5, 2018

Adds Static Headers to a request. Puts in place a no-cache middleware based on this design.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jul 5, 2018

Targeted wrong

@ChristopherDavenport ChristopherDavenport changed the base branch from master to release-0.18.x Jul 5, 2018
@cquiroz
cquiroz approved these changes Jul 5, 2018
Copy link
Member

@cquiroz cquiroz left a comment

LGTM, Should it have some documentation?

Copy link
Member

@rossabaker rossabaker left a comment

Wouldn't object to some scaladoc, like @cquiroz notes, but good enough for me.


object StaticHeaders {

def apply[F[_]: Functor](headers: Headers)(service: HttpService[F]): HttpService[F] =

This comment has been minimized.

@rossabaker

rossabaker Jul 5, 2018
Member

We'll of course want to genericize this in the merge to master.

@ChristopherDavenport ChristopherDavenport merged commit abcd8e6 into http4s:release-0.18.x Jul 5, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ChristopherDavenport ChristopherDavenport deleted the ChristopherDavenport:staticHeadersMiddleware branch Jul 5, 2018
@rossabaker rossabaker mentioned this pull request Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.