add play json module #1946
add play json module #1946
Conversation
How can I disable mima for this new module?
|
I fixed mima and other formatting issue. However, I don't know why the last build is hanging: |
I may need some help to investigate the build failure, I don't really know where to look atm |
Wow. That's surprising. Does the 2.11 build fail locally? |
@rossabaker probably the problem is that I can't seem to run the test locally, I tried both:
should I run another command? |
I'm not sure what client tests you saw fail, but I used to get client failures on OSX with regard to resolving localhost. I solved these by moving back to Linux. I saw a linker error when running |
Thank Ross for having a look. FYI, I am getting test failures for JavaNetClient and OkHttpClient:
It might be related to my work network. I will try from home. Regarding you config change, it seems that sbt doesn't accept
I get the same error locally. |
Ugh. I had it passing, and got a couple commits tangled, and untangled them, and pushed the wrong state. Sorry about that. Looking again. |
Build passes finally. We missed a couple copy-and-paste issues on implicit names. |
* Derive [[EntityDecoder]] if implicit [[Reads]] is in the scope without need to explicitly call `jsonOf` | ||
*/ | ||
trait PlayEntityDecoder { | ||
implicit def circeEntityDecoder[F[_]: Sync, A: Reads]: EntityDecoder[F, A] = jsonOf[F, A] |
rossabaker
Aug 13, 2018
Member
Should not call this circe
.
Should not call this circe
.
* Derive [[EntityEncoder]] if implicit [[Writes]] is in the scope without need to explicitly call `jsonEncoderOf` | ||
*/ | ||
trait PlayEntityEncoder { | ||
implicit def circeEntityEncoder[F[_]: Applicative, A: Writes]: EntityEncoder[F, A] = |
rossabaker
Aug 13, 2018
Member
Should not call this circe
.
Should not call this circe
.
julien-truffaut
Aug 13, 2018
Author
Member
thanks I will fix this
thanks I will fix this
No description provided.