Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RequestLoggerRedaction #1950. Supercedes PR #1951. #1952

Merged
merged 1 commit into from Jul 13, 2018

Conversation

@IssueMonoid
Copy link
Contributor

@IssueMonoid IssueMonoid commented Jul 12, 2018

Added redactHeadersWhen arg to Logger.logMessage

In the !logBody branch of RequestLogger this argument was accidentally
not passed, causing the default value to be used, potentially logging
sensitive headers.

In the !logBody branch of RequestLogger this argument was accidentally
not passed, causing the default value to be used, potentially logging
sensitive headers.
@aeons aeons merged commit ef04f12 into http4s:release-0.18.x Jul 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.