Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw ConnectException on connection failure in blaze client #1963

Merged
merged 2 commits into from Jul 26, 2018

Conversation

@nigredo-tori
Copy link
Contributor

@nigredo-tori nigredo-tori commented Jul 26, 2018

This currently throws an IOException, which is far too general.

Copy link
Member

@rossabaker rossabaker left a comment

Good change. Compatible, but improved. Thanks!

@aeons aeons merged commit 45d34a7 into http4s:master Jul 26, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@nigredo-tori nigredo-tori deleted the nigredo-tori:patch-1 branch Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants