Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JettyBuilder: Clean up HTTP/HTTPS configuration #1996

Merged
merged 1 commit into from Aug 19, 2018

Conversation

@nigredo-tori
Copy link
Contributor

@nigredo-tori nigredo-tori commented Aug 15, 2018

  1. HttpConfiguration.setSecurePort and HttpConfiguration.setSecureScheme are a part of the mechanism for redirecting some requests to another (secure) port/scheme. Setting them for HTTPS connector doesn't do anything. See this example.
  2. ServerConnector has constructors that build an SslConnectionFactory and HttpConnectionFactory automatically.
  3. SecureRequestCustomizer is automatically added for HTTP connection factories if an SSL context factory is provided - no need to do this manually.
Copy link
Member

@rossabaker rossabaker left a comment

This is a nice simplification. Thanks!

@rossabaker rossabaker added this to the 0.19.0-M2 milestone Aug 15, 2018
@rossabaker rossabaker merged commit 867cb8c into http4s:master Aug 19, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nigredo-tori nigredo-tori deleted the nigredo-tori:clean-up-jetty-builder branch Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants