Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Topic/status.register 2015 #2032
This is intended to address issue #2015 which was initially about making
The first forAll check was completely being ignored here (not being the last expression in the block, it wasn’t returned, so it was never evaluated). This has been fixed by breaking out the assertions into separate tests.
Thanks. This looks great, but I think we had one small miscommunication here: we don't want to register custom status codes, but we want to allow their creation if the number is valid. See the comment on
isInRange, which will also affect a couple of your tests.
Hopefully, this incorporates the suggestions.
Looks like I spoke too soon.
I've eliminated its use. I also took the opportunity to turn the registry into an
This looks almost there. I'd change that default reason phrase, and I think we're ready.