Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add jetty backend for http4s client #2036
also, quoting the jetty client doc:
I'm not entirely sure how to enable this kind of "fine-grained control of the req/resp conversation" given the current implementation
I think there are some subtleties that are nicely covered by wrapping the jetty-reactive-httpclient, but each dependency is a liability, and would add the overhead of the fs2-reactive-streams bridge when we should be able to implement this directly. I could argue either side. Which do you feel better about, having written both?
I think you might have the "fine-grained" control right: you're providing the request body asynchronously, and I don't see how you could receive the response headers before the request headers are sent. I suppose we might get more sophisticated about not continuing to send to the deferred content provider?
Thanks, and sorry for the delay. The cats-effect-1.0 push consumed us for a bit.
This is looking really good. Just a couple more nitpicks, and I think we're ready to go.