Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix hang on master #2050
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'd rather replace |
jmcardon
force-pushed the
jmcardon:fix-ws-hang
branch
from
607491a
to
6c20654
Sep 5, 2018
rossabaker
reviewed
Sep 5, 2018
jmcardon
dismissed
rossabaker’s
stale review
Sep 5, 2018
Tests are erroring out
This comment has been minimized.
This comment has been minimized.
|
This change is a tad bigger than I thought it was, one test is erroring out. |
jmcardon
force-pushed the
jmcardon:fix-ws-hang
branch
from
6c20654
to
75be580
Sep 5, 2018
This comment has been minimized.
This comment has been minimized.
|
I changed the pool to use the global pool purely for my test which abuses concurrency. |
rossabaker
approved these changes
Sep 5, 2018
It stops the bleeding. We can clean up the test pools later.
rossabaker
merged commit f5416cd
into
http4s:master
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jmcardon commentedSep 5, 2018
No description provided.