New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames incorrect, duplicate withIdleTimeout to withMaxTotalConnections #2069

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@MarkusA380

MarkusA380 commented Sep 11, 2018

This fixes the name of a duplicate function withIdleTimeout that should actually be named withMaxTotalConnections. The implementation is already correct, and the real def withIdleTimeout(idleTimeout: Duration): BlazeClientBuilder[F] remains untouched.

@rossabaker

I knew I should have automated the generation of those.

Thanks!

@rossabaker rossabaker added the bug label Sep 11, 2018

@rossabaker rossabaker added this to the 0.19.0-M3 milestone Sep 11, 2018

@aeons

This comment has been minimized.

Member

aeons commented Sep 12, 2018

Build failure looks unrelated.

@aeons aeons merged commit a005518 into http4s:master Sep 12, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment