Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
rossabaker
approved these changes
Sep 11, 2018
I knew I should have automated the generation of those.
Thanks!
rossabaker
added
the
bug
label
Sep 11, 2018
rossabaker
added this to the
0.19.0-M3 milestone
Sep 11, 2018
This comment has been minimized.
This comment has been minimized.
|
Build failure looks unrelated. |
aeons
merged commit a005518
into
http4s:master
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MarkusA380 commentedSep 11, 2018
This fixes the name of a duplicate function
withIdleTimeoutthat should actually be namedwithMaxTotalConnections. The implementation is already correct, and the realdef withIdleTimeout(idleTimeout: Duration): BlazeClientBuilder[F]remains untouched.