Renames incorrect, duplicate withIdleTimeout to withMaxTotalConnections #2069
Conversation
|
I knew I should have automated the generation of those. Thanks! |
|
Build failure looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes the name of a duplicate function
withIdleTimeoutthat should actually be namedwithMaxTotalConnections. The implementation is already correct, and the realdef withIdleTimeout(idleTimeout: Duration): BlazeClientBuilder[F]remains untouched.