Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queue full exception specific #2078

Closed
wants to merge 1 commit into from

Conversation

@keirlawson
Copy link
Contributor

@keirlawson keirlawson commented Sep 12, 2018

No description provided.

Keir Lawson
Copy link
Member

@rossabaker rossabaker left a comment

If we cherry-pick this back to release-0.18.x, it could even go into a patch release.

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Sep 12, 2018

Weird place for the model though. Do we instead want it in an errors or in the companion object?

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 12, 2018

NoConnectionAllowedException is already in the same place. We could bikeshed that, but as with one, with the other.

@SystemFw
Copy link
Member

@SystemFw SystemFw commented Sep 12, 2018

Is this ready for merge, or should I bring some paint? :)

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 12, 2018

@keirlawson asked about 0.18 support. I think we should cherry-pick rather than merge.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 12, 2018

Cherry picked onto release-0.18.x, merged back to master.

@rossabaker rossabaker closed this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.