Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2071 use read range of fs2 #2079

Merged
merged 3 commits into from Sep 26, 2018

Conversation

@asarturas
Copy link
Contributor

@asarturas asarturas commented Sep 12, 2018

Beware, this PR depends on change in fs2 (typelevel/fs2#1257) and will fail the build until that one is merged

asarturas added 2 commits Sep 12, 2018
Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int#2071 Use readRange of FS2

Beware - we're changing long to int
…ld when that one is merged
@asarturas
Copy link
Contributor Author

@asarturas asarturas commented Sep 12, 2018

fixes #2071

Copy link
Member

@rossabaker rossabaker left a comment

Nitpick: we usually sort our imports alphabetically.

Logistically, I think we'll keep this open, and merge it after we have the next fs2 release.

@rossabaker rossabaker added this to the 0.19.0-M3 milestone Sep 23, 2018
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 26, 2018

Should be green after merging #2119.

@aeons aeons merged commit ec1e060 into http4s:master Sep 26, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.