Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete redundant OkHttp code #2081

merged 1 commit into from Sep 13, 2018


Copy link

@rossabaker rossabaker commented Sep 13, 2018

This whole implementation exists in OkHttpBuilder.

This has the curious effect that all OkHttp logging is done in the org.http4s.client.okhttp.OkHttpBuilder logger, even for a built client. We might relocate some of the remaining code, but it would be purely for logger name purposes.

aeons approved these changes Sep 13, 2018
@aeons aeons merged commit 68e1df7 into http4s:master Sep 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@rossabaker rossabaker deleted the rossabaker:delete-redundant-okhttp branch Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants