Record intermediate redirect locations #2093
Merged
Conversation
added 4 commits
Sep 9, 2018
Add test to assert that intermediate URIs are returned Run response transform after prepareLoop Use the top-level test app Move attribute key closer to accessor function Fix test name Add documentation
|
This looks good to me, but I've been on a plane for five hours and I dont understand why this isn't building the list of redirects in reverse order. It prepends, but the test shows 1, 2, 3. I will look again when I'm less tired. |
|
@rossabaker Nice catch! Prepending the list threw me for a spin too and I only wrote the feature a few days ago |
|
Oh, right. Which works out nicely for This seems binary compatible to me. We can backport this if you'd like this in the 0.18 series. |
|
The build is failing because we need to run |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi!
I've added tracking redirect locations in the response attributes. I've also pulled the status code handling logic into a separate function.