Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unusedCompileDependenciesTest #2113

Merged
merged 2 commits into from Sep 25, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 25, 2018

Fails the build if we declare a dependency we don't use. Prevents us from passing liabilities downstream.

Not enforced on private (e.g. unpublished) projects.

Bonus: stop publishing empty http4s-tests module.

@rossabaker rossabaker added the CI label Sep 25, 2018
@aeons
aeons approved these changes Sep 25, 2018
@cb372
Copy link
Contributor

@cb372 cb372 commented Sep 25, 2018

Looks like it fails for only the primary Travis job, where scoverage is enabled:

[warn] mimedb-generator >>> The following libraries are declared in libraryDependencies but are not needed for compilation:
[warn]  - "org.scoverage" %% "scalac-scoverage-runtime" % "1.3.1"

Not sure how to work around that, other than adding support in the plugin for manually excluding certain dependencies as I suggested at cb372/sbt-explicit-dependencies#13 (comment). I'll try and get that implemented in the next few days.

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Sep 25, 2018

We have a PrivateProjectsPlugin that disables scoverage on certain modules. That's where the call to disable the dependency test really belonged. That should make this green even without the new feature, though I think it's a good one to have.

@rossabaker rossabaker merged commit ac2362b into http4s:master Sep 25, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants