Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scala and sbt #2130

Merged
merged 1 commit into from Sep 27, 2018
Merged

Upgrade scala and sbt #2130

merged 1 commit into from Sep 27, 2018

Conversation

@aeons
Copy link
Member

@aeons aeons commented Sep 27, 2018

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

Did Scala get stricter about unused parameters?

@@ -110,7 +110,7 @@ class ScienceExperiments[F[_]] extends Http4sDsl[F] {
Stream
.eval(F.pure(Chunk.bytes(Array(' '.toByte))))
.evalMap(_ =>
F.async[Byte] { cb => /* hang */
F.async[Byte] { _ => /* hang */

This comment has been minimized.

@rossabaker

rossabaker Sep 27, 2018
Member

This could be F.never now.

This comment has been minimized.

@aeons

aeons Sep 27, 2018
Author Member

Also on 0.18?

@aeons
Copy link
Member Author

@aeons aeons commented Sep 27, 2018

Yea, looks like it.

@rossabaker rossabaker merged commit 934a69a into http4s:release-0.18.x Sep 27, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeons aeons deleted the aeons:bump-scala-sbt branch Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants