Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Client.streaming with Client.stream #2136

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 30, 2018

Based on @ChristopherDavenport's good idea in #1714. The abstract method is still based on Resource, but a Stream[F, Response[F]] is simpler than .streaming, and .streaming can be easily derived from it.

@rossabaker rossabaker added this to the 0.19.0-RC1 milestone Sep 30, 2018
@rossabaker rossabaker requested a review from ChristopherDavenport Sep 30, 2018
@rossabaker rossabaker force-pushed the rossabaker:client-streaming branch from a0a565d to 7dacaaf Sep 30, 2018
@aeons
aeons approved these changes Sep 30, 2018
@rossabaker rossabaker merged commit 3efdc89 into http4s:master Oct 2, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker rossabaker deleted the rossabaker:client-streaming branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.