Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Response.timeout from 500 to 503 - ServiceUnavailable #2151

Merged
merged 1 commit into from Oct 5, 2018

Conversation

@dwalend
Copy link

@dwalend dwalend commented Oct 5, 2018

Response.timeout is currently only used by AsyncHttp4sServlet, so I think this change is extremely low risk.

A 503 ("The server is currently unavailable (because it is overloaded or down for maintenance). Generally, this is a temporary state") code is more appropriate to a timeout than the generic 500 ("A generic error message" that something broke horribly). We also considered and rejected 429 ("The user has sent too many requests") because it blames the client for a server problem.

@cquiroz
cquiroz approved these changes Oct 5, 2018
Copy link
Member

@cquiroz cquiroz left a comment

LGTM

@rossabaker rossabaker merged commit c76d35f into http4s:master Oct 5, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.