New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2157 Set default 1 minute timeout for all http clients #2159

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@kaishh
Contributor

kaishh commented Oct 9, 2018

No description provided.

@kaishh kaishh force-pushed the kaishh:feature/set-default-one-minute-timeout-for-http-clients branch from ebcdf19 to 12a69e4 Oct 9, 2018

@rossabaker

👍, but I'd like to hear others' take on my question below.

@@ -26,7 +26,7 @@ object AsyncHttpClient {
val defaultConfig = new DefaultAsyncHttpClientConfig.Builder()
.setMaxConnectionsPerHost(200)
.setMaxConnections(400)
.setRequestTimeout(30000)
.setRequestTimeout(60000)

This comment has been minimized.

@rossabaker

rossabaker Oct 9, 2018

Member

This raises an interesting philosophical point: should there be an http4s default for all client backends, that's as similar as possible, or should we default to the backends' defaults?

This comment has been minimized.

@kaishh

kaishh Oct 9, 2018

Contributor

I think we should set our defaults, since http4s is the principal abstraction here. - users would probably be surprised if changing the backend, while staying within http4s would change defaults.

This comment has been minimized.

@rossabaker

rossabaker Oct 9, 2018

Member

I think that's a reasonable position.

Maybe we should have a defaults object in client to centralize all that, and then adapt as well as we can in each of the backends.

This comment has been minimized.

@ChristopherDavenport

ChristopherDavenport Oct 9, 2018

Member

I like a second PR to do the latter. As I think there will likely be more than this that we will want to change in that PR. But I think it would be a good idea.

@rossabaker rossabaker merged commit 1054a20 into http4s:master Oct 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kaishh kaishh deleted the kaishh:feature/set-default-one-minute-timeout-for-http-clients branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment