Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Clock to manage blaze request timeouts #2166

Merged
merged 6 commits into from Oct 13, 2018
Merged

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Oct 12, 2018

Fixes #2156.

The test could be faster if we passed in a custom clock. The implementation could be smarter by not creating a zeroed timeout stage specifically to fail. But this represents a red-to-green bugfix.

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Oct 12, 2018

Going to need to exclude 0.19.0 from the MiMa check since it exists.

@rossabaker rossabaker force-pushed the rossabaker:issue-2156 branch from df3bb9a to 6ed25c5 Oct 13, 2018
@rossabaker rossabaker force-pushed the rossabaker:issue-2156 branch from 6ed25c5 to a87adb6 Oct 13, 2018
Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

👍 after scalafmt

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Oct 13, 2018

Ouch caught by tut that now needs a timer.

rossabaker added 2 commits Oct 13, 2018
@rossabaker rossabaker merged commit 1a2153a into http4s:master Oct 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants