Add Allocate builders #2168
Merged
Add Allocate builders #2168
Conversation
|
Ooh, I was thinking you'd need to copy that interpreter, but you're still in control. This is less terrible than I thought. Looks good, but you can simplify the |
...t/src/main/scala/org/http4s/client/asynchttpclient/AsyncHttpClient.scala
Outdated
Show resolved
Hide resolved
|
Could do the same for servers for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #2167