Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Allocate builders #2168

Merged
merged 5 commits into from Oct 13, 2018
Merged

Conversation

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Oct 13, 2018

Fixes #2167

Copy link
Member

@rossabaker rossabaker left a comment

Ooh, I was thinking you'd need to copy that interpreter, but you're still in control. This is less terrible than I thought.

Looks good, but you can simplify the allocate -> resource translations.

@rossabaker rossabaker merged commit 8f5751d into http4s:master Oct 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Oct 13, 2018

Could do the same for servers for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants