Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
ChristopherDavenport
added some commits
Oct 13, 2018
rossabaker
reviewed
Oct 13, 2018
Ooh, I was thinking you'd need to copy that interpreter, but you're still in control. This is less terrible than I thought.
Looks good, but you can simplify the allocate -> resource translations.
rossabaker
merged commit 8f5751d
into
http4s:master
Oct 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Could do the same for servers for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ChristopherDavenport commentedOct 13, 2018
Fixes #2167