Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence expected exceptions #2179

Merged
merged 3 commits into from Oct 18, 2018

Conversation

@entangled90
Copy link

@entangled90 entangled90 commented Oct 16, 2018

Stack trace that print directly to stderr are suppressed, while exceptions logged at error level are still logged.
Should these logs be suppressed too?
Any advice on the "copyright" for the copied function from cats-effect?

Closes issue #2049

Carlo Sana added 2 commits Oct 16, 2018
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Oct 18, 2018

We usually leave an attribution like this. You want to copy the copyright of whatever you copied. And then make sure the project is mentioned in NOTICE, but it already is.

Thanks for this!

@entangled90
Copy link
Author

@entangled90 entangled90 commented Oct 18, 2018

@rossabaker Added attribution like you requested. I resolved WIP status, you can merge it if you feel like it.
Thanks!

@entangled90 entangled90 changed the title WIP: Silence expected exceptions Silence expected exceptions Oct 18, 2018
Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Love it! 👍

@rossabaker rossabaker merged commit bece7a5 into http4s:master Oct 18, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants